[HOME PAGE] [STORES] [CLASSICISTRANIERI.COM] [FOTO] [YOUTUBE CHANNEL]

Bug 66460 – VisualEditor: Design a good solution for image alignment "none" vs "default"

Last modified: 2014-06-11 06:31:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 66460 - VisualEditor: Design a good solution for image alignment "none" vs "default"


Summary:	VisualEditor: Design a good solution for image alignment "none" vs "default"

Status:	ASSIGNED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High enhancement
Target Milestone:	---
Assigned To:	Editing team bugs – take if you're interested!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ve-mediasupport
	Show dependency tree / graph

Reported:	2014-06-10 22:50 UTC by Moriel Schottlender
Modified:	2014-06-11 06:31 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Word 2013 image alignment menu (9.67 KB, image/png) 2014-06-10 22:57 UTC, Moriel Schottlender	Details
Word 2013 image popup menu (17.29 KB, image/png) 2014-06-10 22:57 UTC, Moriel Schottlender	Details
Word 2013 image position menu (9.18 KB, image/png) 2014-06-10 22:58 UTC, Moriel Schottlender	Details
Word 2013 image wrap text menu (11.44 KB, image/png) 2014-06-10 22:59 UTC, Moriel Schottlender	Details
Image alignment in Google Docs (10.64 KB, image/png) 2014-06-10 23:16 UTC, Moriel Schottlender	Details
Add an attachment (proposed patch, testcase, etc.)

Description Moriel Schottlender 2014-06-10 22:50:52 UTC

There is a difference in behavior between explicitly stating "none" in the image wikitext and setting no alignment (which is usually default) This difference is especially complicated when we're dealing with switching between block to inline, as inline images basic/frameless have no initial alignment (attrs.align = undefined) but if an alignment is chosen in basic/frameless they turn into blocks.

There is no real way to choose "none" alignment for inline blocks with our current GUI.

You can see the outcome and differences between default/no alignment to 'none' and other alignments in each of the different image types in this table:
https://www.mediawiki.org/wiki/User:Mooeypoo/VE_ImageAlignment


I've tried to explore what other programs do in this case, but there doesn't seem to be a good analogy for the difference between having 'float' value and not having a float value while mixing block with inline. 

In Microsoft Word 2013, images are inserted as block image with default alignment that is the direction of the text (left for ltr, right for rtl) *BUT* without text wrapping - so no float. You can change the image to inline ("In Line with Text") or to be wrapped ("With Text Wrapping") but the wrapping options are limited to how close the text is around the image; the user is then allowed to manually drag the image wherever they want ti to be (no actual 'left' / 'center' / 'right')

We should find a working solution to let users decide between having 'none' alignment explicitly while still having the default value available for both inline and block images.

Comment 1 Moriel Schottlender 2014-06-10 22:57:24 UTC

Created attachment 15623 [details]
Word 2013 image alignment menu

Comment 2 Moriel Schottlender 2014-06-10 22:57:45 UTC

Created attachment 15624 [details]
Word 2013 image popup menu

Comment 3 Moriel Schottlender 2014-06-10 22:58:04 UTC

Created attachment 15625 [details]
Word 2013 image position menu

Comment 4 Moriel Schottlender 2014-06-10 22:59:19 UTC

Created attachment 15626 [details]
Word 2013 image wrap text menu

Comment 5 Moriel Schottlender 2014-06-10 23:16:46 UTC

Created attachment 15627 [details]
Image alignment in Google Docs

Comment 6 Moriel Schottlender 2014-06-10 23:19:12 UTC

Interestingly enough, in Google Docs you seem to have three main alignment options:

* In line - an inline image
* Wrap text - Block image with floating, you can then drag/drop it either left, center or right in the text and choose how small the margin to the text is.
* Break text - this is just like our "none" option, it's an image in its own line that is automatically aligned to the text (so, left in LTR)

The functionality (drag/drog) and some options aren't all relevant, but maybe we could get some ideas from the naming of the features.

Comment 7 James Forrester 2014-06-11 00:36:04 UTC

(In reply to Moriel Schottlender from comment #6)
> Interestingly enough, in Google Docs you seem to have three main alignment
> options:
> 
> * In line - an inline image
> * Wrap text - Block image with floating, you can then drag/drop it either
> left, center or right in the text and choose how small the margin to the
> text is.
> * Break text - this is just like our "none" option, it's an image in its own
> line that is automatically aligned to the text (so, left in LTR)
> 
> The functionality (drag/drog) and some options aren't all relevant, but
> maybe we could get some ideas from the naming of the features.

Dragging to the left/right/centre actually could be really nice, but we'd probably want both that and a way to set it in the dialog I think.

"Inline" vs. "Break text" vs. "Wrap text" seems reasonable language…

Comment 8 Moriel Schottlender 2014-06-11 06:31:08 UTC

The comparison to wikitext functionality should be something like:
* In line: frameless/basic without alignment
* Wrap text: thumb/frame/frameless/basic with explicit right/left alignment
* Break line: thumb/frame/frameless/basic with either "center" or "none" alignments. No float, no text wrap.

The only problem in that case would be to adjust the fine print of the behavior, but in general terms it would be more or less consistent to the user.

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9