Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 648 - link-text disappears from image alt/title attributes


Summary:	link-text disappears from image alt/title attributes

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	1.4.x
Hardware:	All All

Importance:	Normal normal with 3 votes (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	parser

Duplicates:	1332 1568 1974 2061 2133 (view as bug list)
Depends on:	689
Blocks:	367
	Show dependency tree / graph

Reported:	2004-10-05 12:16 UTC by Rowan Collins [IMSoP]
Modified:	2010-05-15 15:33 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rowan Collins [IMSoP] 2004-10-05 12:16:49 UTC

When an image's alt and/or title attributes are generated from a caption with a
link in, the text of the link disappears. For example: "[[Image:Foo|thumb|text
with a [[link]] in it]]" should become "text with a link in it", but currently
becomes "text with a  in it".

This may or may not still be a problem once bug 368 is closed - depending what
combination of default values we decide to use.

The problem arises because internal links are replaced by placeholders, which
are comments, so the text of the link is not available once the caption is being
processed. It is removed by a substitution which blanks all HTML tags (which at
least lets external links appear correctly); otherwise, it would appear as
something like "text with a &lt;!-- Link 14 --&gt; in it".

The only approach I can think of, is that it might be possible to somehow
retrieve the link text from the placeholder code.

Comment 1 Wil Mahan 2004-10-05 18:35:30 UTC

(In reply to comment #0)
> This may or may not still be a problem once bug 368 is closed - depending what
> combination of default values we decide to use.

I'm arguing for fixing bug 368 in a way that will make it unnecessary to
address this. Besides being the unique in that it can contain links,
the caption may actually contain other images, and it is in general
a longer description that serves a separate function from the "alt"
and "title" attributes.

> The only approach I can think of, is that it might be possible to somehow
> retrieve the link text from the placeholder code.

That would certainly be possible, and if my approach is not adopted,
I think that would be the way to go.

Comment 2 Rowan Collins [IMSoP] 2005-01-14 01:42:41 UTC

(In reply to comment #0)
> The only approach I can think of, is that it might be possible to somehow
> retrieve the link text from the placeholder code.

Looking at how things seem to work, it looks like this would indeed be a viable
approach; *but*, the code which *parses* image options is in *Skin.php*, whereas
the link-stripping is so far all in Parser.php, so I'd much rather leave this
one until I or someone else gets round to putting the image parser in the parser
class. I started on that once, but I didn't quite iron out the creases, so I
must get back and finish it off.

Comment 3 Rowan Collins [IMSoP] 2005-01-15 12:26:15 UTC

*** Bug 1332 has been marked as a duplicate of this bug. ***

Comment 4 Brion Vibber 2005-02-20 13:05:22 UTC

*** Bug 1568 has been marked as a duplicate of this bug. ***

Comment 5 Rowan Collins [IMSoP] 2005-03-03 17:03:50 UTC

Note that this has now been fixed by what is described as a "gross hack" in CVS
HEAD - because images are parsed in Skin.php (or rather the new helper class
Linker.php), it has to use the global Parser object to replace the place-holder.
If I ever get round to finishing my patch (bug 689), this will no longer be
necessary.

Comment 6 Brion Vibber 2005-04-25 13:04:15 UTC

*** Bug 1974 has been marked as a duplicate of this bug. ***

Comment 7 Brion Vibber 2005-05-03 12:07:40 UTC

*** Bug 2061 has been marked as a duplicate of this bug. ***

Comment 8 Brion Vibber 2005-05-10 08:41:04 UTC

*** Bug 2133 has been marked as a duplicate of this bug. ***

Comment 9 lɛʁi לערי ריינהארט 2005-10-05 09:16:23 UTC

Hallo!

This bug seems to be fixed; see [[en:User:Gangleri/tests/bugzilla/images]]

Best regards Reinhardt [[user:gangleri]]

Comment 10 Rob Church 2005-10-05 13:30:30 UTC

When reporting bugs fixed, marked them as such.

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9