Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 5985 - Allow images in the bad image to be used on specific pages


Summary:	Allow images in the bad image to be used on specific pages

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	1.7.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-05-16 17:23 UTC by Ilmari Karonen
Modified:	2006-09-25 03:04 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch to allow exceptions to to bad image list (2.61 KB, patch) 2006-05-16 17:26 UTC, Ilmari Karonen	Details
New patch against revision 14260 (4.69 KB, patch) 2006-05-16 23:19 UTC, Ilmari Karonen	Details
Updated patch: link to image page in galleries, don't show bad images in categories (7.06 KB, patch) 2006-05-17 00:20 UTC, Ilmari Karonen	Details
Patch to allow exceptions to to bad image list (simplified, against svn HEAD) (4.74 KB, patch) 2006-06-29 20:25 UTC, Ilmari Karonen	Details
Patch to allow exceptions to to bad image list (simplified, depends on bugs 6490 and 6491) (5.35 KB, patch) 2006-06-29 20:27 UTC, Ilmari Karonen	Details
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Description Ilmari Karonen 2006-05-16 17:23:56 UTC

The MediaWiki:Bad_image_list feature would be much more useful if the images
listed in it could be allowed on specific pages.  I'd propose the following
syntax for specifying such exceptions:

 * [[:Image:Bad image.jpg]] : [[Page to allow it on]], [[Another page]],
[[Namespace:Third page]]

or, alternatively, using definition list syntax:

 ; [[:Image:Bad image.jpg]] : [[Page to allow it on]], [[Another page]],
[[Namespace:Third page]]

Comment 1 Ilmari Karonen 2006-05-16 17:26:57 UTC

Created attachment 1754 [details]
Patch to allow exceptions to to bad image list

This patch implements the syntax proposed above.  Both variants are supported. 
Exceptions may also be listed on a separate line (or lines), prefixed with a
colon, just like in normal MediaWiki definition lists.

Comment 2 Ilmari Karonen 2006-05-16 23:19:06 UTC

Created attachment 1760 [details]
New patch against revision 14260

I've made a new patch that works with the ImageGallery.php fixes committed by
robchurch.  I make no comment on whether mParsing is (or was) a descriptive
name for the property I've co-opted -- nonetheless, I've left it as is for now.

Comment 3 Ilmari Karonen 2006-05-16 23:23:07 UTC

The ImagePage.php code should ideally link the image name to the image
description page.  This is, however, a very low priority issue.

Comment 4 Ilmari Karonen 2006-05-17 00:20:35 UTC

Created attachment 1762 [details]
Updated patch: link to image page in galleries, don't show bad images in categories

This is an update of the previous patch with better gallery rendering,
including a link to the image description page.  This involved a significant
reorganization of ImageGallery::toHTML(), which, however, was IMO in need of
one anyway.  Also, this patch contains a one-line addition to CategoryPage.php
that makes the bad image list also affect galleries.

Comment 5 Ilmari Karonen 2006-06-29 20:25:57 UTC

Created attachment 2025 [details]
Patch to allow exceptions to to bad image list (simplified, against svn HEAD)

This is a simplified patch that does not include unrelated cleanup to
ImageGallery.php (bug 6490) and does not extend the scope of the bad image list
to galleries (bug 6491).

Comment 6 Ilmari Karonen 2006-06-29 20:27:50 UTC

Created attachment 2026 [details]
Patch to allow exceptions to to bad image list (simplified, depends on bugs 6490 and 6491)

Alternative patch that may be applied on top of the patches for bug 6490 and
bug 6491.

Comment 7 Ilmari Karonen 2006-06-29 20:30:55 UTC

Note that the two patches above differ from the previous ones in that the syntax
for the exceptions is stricter: lines must begin with "*" (not ";") and all
exceptions must be listed on the same line as the image.  However, the colon
between the image and the exceptions is no longer required.

Comment 8 Tim Starling 2006-09-25 03:04:10 UTC

I wasn't aware of this patch so I just wrote my own feature that does the same
thing.

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9