Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 5930 - Renameuser does not update the `archive` table


Summary:	Renameuser does not update the `archive` table

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Renameuser (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal with 4 votes (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	schema-change

Duplicates:	9020 10048 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-05-13 04:38 UTC by Yaohua2000
Modified:	2008-03-01 16:27 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yaohua2000 2006-05-13 04:38:40 UTC

See the log:
http://en.wikipedia.org/w/index.php?title=Special:Log&user=Yaohua2000

See the contribution:
http://en.wikipedia.org/wiki/Special:Contributions/Yaohua2000

A user created on April 14, 2006 made an edit on October 25, 2005.

What cause this problem is that the article had been deleted but undeleted
recently, User:Yaohua2000 renamed before the undeletion.

Please fix the bug.

Comment 1 Rob Church 2006-05-13 13:02:18 UTC

The Renameuser extension has the lines which would change the archive table
commented out, apparently for performance reasons.

Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-18 15:55:33 UTC

*** Bug 9020 has been marked as a duplicate of this bug. ***

Comment 3 Rotem Liss 2007-02-18 16:01:43 UTC

It is not updated by purpose - see r13413. Introducing some better indexes for
this table instead of disabling the updates may be better, though.

Comment 4 Rob Church 2007-02-18 16:12:34 UTC

Note that RenameUser can now be configured to update this table; the default for
this option is the same as $wgMiserMode, so on sites where expensive operations
are switched off, so will archive table updates be. This can be overridden, of
course.

Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-28 18:13:46 UTC

*** Bug 10048 has been marked as a duplicate of this bug. ***

Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-28 18:15:19 UTC

(From bug 10048 comment #1)
> There is no usertext index on the archive table, so renaming deleted edits
> would be a performance issue.

Why can't we just add such an index?  Surely archive is vastly smaller than revision.

Comment 7 Aaron Schulz 2007-05-28 18:17:36 UTC

(In reply to comment #6)
> (From bug 10048 comment #1)
> > There is no usertext index on the archive table, so renaming deleted edits
> > would be a performance issue.
> 
> Why can't we just add such an index?  Surely archive is vastly smaller than
> revision.
> 

Adding an index would enable my deletecontributions extension too :)

However see http://www.mediawiki.org/wiki/Extension_talk:DeletedContributions.

Comment 8 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-28 18:23:18 UTC

(In reply to comment #7)
> However see http://www.mediawiki.org/wiki/Extension_talk:DeletedContributions.

I.e., "schema updates are disruptive".  Well, yeah.  :)  It can still be put in line with the other updates.  And it's not like rev_deleted is going to instantly phase out the archive table in the next month or something.

Comment 9 とある白い猫 2007-05-28 20:06:54 UTC

* Zscout370 deleted own talk page over "HD DVD code pasted there several times"
which has been overnighted out by now probably 

http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=delete&user=&page=User+talk%3AZscout370

* Raul654 renamed my account from Cool_Cat -> White_Cat 

http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=renameuser&user=Raul654&page=

* Zscout370 restored his talk page after the move

http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=delete&user=&page=User+talk%3AZscout370

* User:Cool_Cat has some of User:White_Cat's contributions now:

http://en.wikipedia.org/wiki/Special:Contributions/Cool_Cat 

----

I believe this is a bug. Deleted edits do not seem to be properly "renamed". It
may be unique to the case so additional review is necessary.

Comment 10 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-29 04:50:38 UTC

No it's not.  The issue is known and the exact solution necessary is known.  An index has to be added to the appropriate column of the archive table and the code has to be updated accordingly.  Go bother Tim or someone about adding that index if you want.

Comment 11 Aaron Schulz 2007-07-06 02:12:12 UTC

As with enabled deletedcontribs extension, will wait until schema change done.

Comment 12 Rob Church 2007-07-06 18:43:37 UTC

This is an active bug; the schema change is a dependency. The bug is not resolved until the schema change is done and all relevant code is updated.

Comment 13 Aaron Schulz 2007-07-09 19:00:50 UTC

Done in r23915.

Comment 14 とある白い猫 2008-03-01 14:16:29 UTC

Is this really fixed? Cause my edits are still attributed to my former username:

http://en.wikipedia.org/w/index.php?title=Special:Contributions&target=Cool%20Cat

Comment 15 Platonides 2008-03-01 14:41:05 UTC

It is fixed, but for renames from now on.
Although now that it's indexed, shouldn't be hard to do old renamings on request.

Comment 16 とある白い猫 2008-03-01 16:27:53 UTC

I see, can all past renames be processed? This is particularly important for licensing related reasons among other things.

   - White Cat

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9