Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 5725 - maintenance/updaters.inc attempts incorrect mysql conection.


Summary:	maintenance/updaters.inc attempts incorrect mysql conection.

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Installer (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-04-26 14:21 UTC by Mark Clements (HappyDog)
Modified:	2006-04-26 20:42 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark Clements (HappyDog) 2006-04-26 14:21:46 UTC

(This note was posted on mediawiki.org - Don't know if it's a valid bug or not,
I'm adding here so it doesn't get lost --HappyDog).

The bugsystem wont send me an email for a new account and I don't care enough to
follow through via email, so here's a bug report--take it or leave it.

In maintenance/updaters.inc in the function do_interwiki_update(). The
$wgDatabase variable is brought into scope but not passed to the dbsource()
command resulting in PHP attempting to create a new MySQL connection using the
php.ini defaults. This can be fixed by adding the $wgDatabase variable as the
second parameter to the two dbsource() calls in that function.

--169.229.139.92 19:43, 27 February 2006 (UTC)

Comment 1 Antoine "hashar" Musso (WMF) 2006-04-26 19:48:09 UTC

User need to create an Adminsettings.php . It contains the database
user and password for maintenance script, a sample is given and named
Adminsettings.sample .

I added a little comment in update.php (trunk@13876).

Closing as WORKFORME

Comment 2 Rob Church 2006-04-26 20:15:01 UTC

In response to the original issue; the $wgDatabase global is used within the
dbsource() function if a specific database isn't passed to it. Within the
installation and update scopes, this is fine.

In response to the effective problem, I'm going to add a basic check to the
maintenance script to ensure that a connection has been established before
bothering to attempt to update. Reopening until this is done.

Comment 3 Rob Church 2006-04-26 20:42:37 UTC

Now done in SVN trunk, r13880. Will backport to 1.6.

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9