Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 3446 - Don't render diffs by default


Summary:	Don't render diffs by default

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	History/Diffs (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement with 4 votes (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	3365 6936 8488 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-09-12 15:36 UTC by Benoit Mortgat
Modified:	2007-01-14 10:50 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch without user pref (2.82 KB, patch) 2006-02-04 03:08 UTC, Lupin	Details
add user pref (3.52 KB, patch) 2006-02-06 03:58 UTC, Lupin	Details
patch with user pref (4.15 KB, patch) 2006-02-06 04:03 UTC, Lupin	Details
patch with user pref and "show diff with article" link (3.76 KB, patch) 2006-07-20 00:00 UTC, Francesco Cosoleto	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Benoit Mortgat 2005-09-12 15:36:22 UTC

Many requests on the servers are done in order to watch changes (whether it is
vandalism or not).
When users check differences between versions, they don't necessarily want to
have the most recent version being displayed.
It would be a good enhancement if any logged user could choose: displaying the
changed version or not?

Comment 1 Rob Church 2005-09-12 20:28:12 UTC

I thought that the History page allows you to choose whichever diff you wish to
see? The reason for the most recent change being shown under something like
Recent Changes is because, logically, that is what the user expects to see.
Could you explain further if I've misunderstood?

Comment 2 Benoit Mortgat 2005-09-12 20:54:21 UTC

I think there is a misunderstanding!
When you compare two versions of an article, you can see what's changed between
both articles seeing their code and you see also the rendering corresponding
with the last code.
That's true when you click "diff" in the RC, and when you compare two versions
of an article via the History.

I'd like to disable the rendering in my individual preferences, since the
servers are overwhelmed with such requests only to check the nature of recent
Changes.

Nice day

Benoit Mortgat

Comment 3 Rob Church 2005-09-12 20:56:26 UTC

Oh, I see. Yes, I'd agree with that logic.

Comment 4 dake 2005-09-12 23:36:09 UTC

This would be very useful indeed. You don't need to see the whole page to track
down vandalism and such.

Comment 5 David E. Siegel 2006-02-03 22:30:08 UTC

I agree this would be useful. see bug #3365 and 
<http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%
29#Bare_diffs.3F>

Comment 6 Lupin 2006-02-04 03:08:37 UTC

Created attachment 1357 [details]
patch without user pref

This patch adds the diffonly flag which suppresses the article display if
present.

Comment 7 Edward Z. Yang 2006-02-05 20:13:02 UTC

*** Bug 3365 has been marked as a duplicate of this bug. ***

Comment 8 Edward Z. Yang 2006-02-05 20:16:15 UTC

Bug 208 may be related (the external API), but I don't think they have anything
to do with each other. Lupin, would you be able to extend user preferences to
make diffonly apply globally?

Comment 9 Lupin 2006-02-06 03:58:35 UTC

Created attachment 1374 [details]
add user pref

There's an option in Special:Preferences with this patch, under "Misc". You can
override that setting using diffonly=0 or diffonly=1 in the url.

Comment 10 Lupin 2006-02-06 04:03:12 UTC

Created attachment 1375 [details]
patch with user pref

Oops, forgot Messages.php - apologies.

Comment 11 Brion Vibber 2006-02-06 06:34:47 UTC

I'm leery of adding preference options; they complicate things.

Comment 12 Francesco Cosoleto 2006-07-20 00:00:02 UTC

Created attachment 2127 [details]
patch with user pref and "show diff with article" link

I added a "Show diff with article" link in diff generated page with diffonly
flag enabled. Pref or not pref, I think "diffonly" it's fine feature.

Comment 13 Carlos 2007-01-04 14:56:52 UTC

*** Bug 8488 has been marked as a duplicate of this bug. ***

Comment 14 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-01-04 22:09:35 UTC

*** Bug 6936 has been marked as a duplicate of this bug. ***

Comment 15 Ilmari Karonen 2007-01-12 03:40:32 UTC

Fixed in r19141 based on a combination of Francesco's patch with a similar
change I'd written myself.

Comment 16 とある白い猫 2007-01-13 11:34:53 UTC

So how does it work? How can this be implemented into our regular wiki usage?

Comment 17 Rotem Liss 2007-01-13 11:36:49 UTC

(In reply to comment #16)
> So how does it work? How can this be implemented into our regular wiki usage?

This the the commit description:

(bug 3446) Add user preference to hide page content below diffs, can be
overridden by adding diffonly=1 or diffonly=0 to the URL of the diff page

I think it's clear enough.

Comment 18 Francesco Cosoleto 2007-01-14 10:50:25 UTC

Thank you. (Not "Francesco's patch", but Lupin)

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9