[HOME PAGE] [STORES] [CLASSICISTRANIERI.COM] [FOTO] [YOUTUBE CHANNEL]

Bug 28820 – Diffs using rev_id should work when one or both revisions are deleted

Last modified: 2013-04-08 12:27:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 28820 - Diffs using rev_id should work when one or both revisions are deleted


Summary:	Diffs using rev_id should work when one or both revisions are deleted

Status:	NEW

Product:	MediaWiki
Classification:	Unclassified
Component:	History/Diffs (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Brion Vibber

URL:
Whiteboard:
Keywords:

Depends on:	21279
Blocks:	28821
	Show dependency tree / graph

Reported:	2011-05-04 23:33 UTC by FT2
Modified:	2013-04-08 12:27 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description FT2 2011-05-04 23:33:42 UTC

(Forked from bug 21279 comment 33 per Brion)

Per bug 21279, code will be patched so that deleted revisions can be referenced
by their rev_id, and this will work regardless of subsequent delete/undelete activity.

Once this is done, can diff handling be enhanced so that a correct diff will still be generated if one or both rev_id's are deleted revisions.

This would ensure that any diffs posted on-wiki or noted by users for future would be guaranteed to be capable of generation and review regardless of future deletion/undeletion. 

At present a diff between arbitrary deleted revisions, or a deleted and non-deleted revision, is not possible, and if a revision is deleted then any diffs it was once part of, are no longer able to be displayed, even if the user has the appropriate viewing rights to both revisions.

Comment 1 Brion Vibber 2011-05-04 23:38:18 UTC

It's been a while since I poked the diff code, but I think it'll mostly need poking in two places:

1) Actually fetching revs will need to be able to fall back to deleted versions, if you have sufficient permissions. This should be pretty easy.


2) on finding the next/previous revision when not explicitly listed on the URL, which right now will just look in the revision table.

Even just fixing 1) would be *very* useful as it would make a lot of broken links work again.

2) has a potential issue in that it could cause the same link to work differently depending on whether you have access to the deleted revs or not, which might end up confusing. Might want to think about things here.

Comment 2 FT2 2011-05-05 01:42:07 UTC

A possible solution for 2) might be to produce the obvious diff (whatever that is) with a hat note 

"This shows all edits between <X> and <Y>. There are <N> intermediate revisions. The edit immediately previous to <X> has been deleted. The diff for the single edit <X> can be viewed by administrators [LINK here]."

Note You need to log in before you can comment on or make changes to this bug.

Search

Personal tools

Navigation

Links

Contents Listing Alphabetical by Author:

A B C D E F G H I J K L M N O P Q R S T U V W X Y Z Unknown Other

Contents Listing Alphabetical by Title:

# A B C D E F G H I J K L M N O P Q R S T U V W Y Z Other

Medical Encyclopedia

Browse by first letter of topic:

A-Ag	Ah-Ap	Aq-Az	B-Bk	Bl-Bz	C-Cg	Ch-Co
Cp-Cz	D-Di	Dj-Dz	E-Ep	Eq-Ez	F	G
H-Hf	Hg-Hz	I-In	Io-Iz	J	K	L-Ln
Lo-Lz	M-Mf	Mg-Mz	N	O	P-Pl	Pm-Pz
Q	R	S-Sh	Si-Sp	Sq-Sz	T-Tn	To-Tz
U	V	W	X	Y	Z	0-9